Change in vdsm[master]: bridge: usage of yaml schema

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Fri Apr 22 06:55:27 UTC 2016


Piotr Kliczewski has posted comments on this change.

Change subject: bridge: usage of yaml schema
......................................................................


Patch Set 18:

(2 comments)

https://gerrit.ovirt.org/#/c/54528/18/lib/api/schemaapi.py
File lib/api/schemaapi.py:

PS18, Line 93: param.get('defaultvalue'),
             :                                    param.get('defaultvalue')
> is this correct? feels strange
It is strange, will fix.


https://gerrit.ovirt.org/#/c/54528/18/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:

Line 67:             "The method %r does not exist or is not available." % method_name)
Line 68: 
Line 69: 
Line 70: class JsonRpcInvalidParamsError(JsonRpcError):
Line 71:     def __init__(self, msg=None):
> I think better to leave msg="Invalid method parameter(s)" as default
Done
Line 72:         JsonRpcError.__init__(self, -32602, msg)
Line 73: 
Line 74: 
Line 75: class JsonRpcInternalError(JsonRpcError):


-- 
To view, visit https://gerrit.ovirt.org/54528
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia76d8245568514d20e446237bd667d87fb4ad3e8
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list