Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name

edwardh at redhat.com edwardh at redhat.com
Thu Apr 21 21:19:40 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: native ovs: reserve ovsbr0 network name
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/56452/5/tests/network/ovs_test.py
File tests/network/ovs_test.py:

Line 100:     def test_add_network_with_reserved_name(self):
Line 101:         fake_running_config = BaseConfig({}, {})
Line 102:         fake_to_be_added_bonds = {}
Line 103:         fake_kernel_nics = ['eth0']
Line 104:         with self.assertRaises(ne.ConfigNetworkError):
You should confirm we failed on the correct specific error.
Line 105:             ovs_validator.validate_net_configuration(
Line 106:                 ovs_constants.BRIDGE_NAME, {'nic': 'eth0', 'switch': 'ovs'},
Line 107:                 fake_to_be_added_bonds, fake_running_config, fake_kernel_nics)
Line 108: 


-- 
To view, visit https://gerrit.ovirt.org/56452
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ca84142e8fa9f25e76378abe9d05b41af921e7f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list