Change in vdsm[master]: client: do not protect requests on client side

ybronhei at redhat.com ybronhei at redhat.com
Thu Apr 21 12:13:23 UTC 2016


Yaniv Bronhaim has posted comments on this change.

Change subject: client: do not protect requests on client side
......................................................................


Patch Set 1:

(2 comments)

change the parameter name please.

https://gerrit.ovirt.org/#/c/56288/1/lib/vdsm/jsonrpcvdscli.py
File lib/vdsm/jsonrpcvdscli.py:

Line 103:         params = self._prepare_args(class_name, method_name, args, kwargs)
Line 104: 
Line 105:         req = JsonRpcRequest(method, params, reqId=str(uuid4()), protect=False)
Line 106: 
Line 107:         responses = self._client.call(
> When you perform some of the test you can see that it is one of the slowest
I'd do it before sending the request in _client anyway. its cli client, and password should be sensitive to hold as clear strings. but as you prefer
Line 108:             req, timeout=self._timeouts.get(
Line 109:                 method_name,
Line 110:                 kwargs.pop('_transport_timeout', self._default_timeout)))
Line 111:         if responses:


https://gerrit.ovirt.org/#/c/56288/1/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:

Line 93:                               "%s request." % method)
Line 94: 
Line 95: 
Line 96: class JsonRpcRequest(object):
Line 97:     def __init__(self, method, params=(), reqId=None, protect=True):
> it is used to encode password so when a request is logged we see '******' i
I know what it does. please call the parameter protect_passwords
Line 98:         self.method = method
Line 99:         if protect:
Line 100:             self.params = protect_passwords(params)
Line 101:         else:


-- 
To view, visit https://gerrit.ovirt.org/56288
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I197591fbf0fb42647267b6901998324dd02a8080
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list