Change in vdsm[master]: migration: validate progress fields from libvirt
mzamazal at redhat.com
mzamazal at redhat.com
Thu Apr 21 08:29:08 UTC 2016
Milan Zamazal has posted comments on this change.
Change subject: migration: validate progress fields from libvirt
......................................................................
Patch Set 4: Code-Review+1
Fine, I just still suggest adding a notice to the commit message why we need to perform the check and why raising ValueError is the better option.
--
To view, visit https://gerrit.ovirt.org/56378
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6de262ce30f32e908a65d5d44fe8499f6951aa63
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No
More information about the vdsm-patches
mailing list