Change in vdsm[master]: tests: FakeLVM: Always create lv file

alitke at redhat.com alitke at redhat.com
Wed Apr 20 19:29:04 UTC 2016


Adam Litke has posted comments on this change.

Change subject: tests: FakeLVM: Always create lv file
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/56169/2/tests/storagefakelibTests.py
File tests/storagefakelibTests.py:

Line 279:             lvm.activateLVs(self.VG_NAME, [self.LV_NAME])
Line 280:             lv = lvm.getLV(self.VG_NAME, self.LV_NAME)
Line 281:             self.assertTrue(lv.active)
Line 282:             self.assertEqual('a', lv.attr.state)
Line 283:             self.assertTrue(os.path.exists(lv_path))
> new test that creates an lv, activates it, writes data and is then able to 
Done
Line 284: 
Line 285:     def test_changevgtags(self):
Line 286:         with self.base_config() as lvm:
Line 287:             deltags = (blockSD.STORAGE_UNREADY_DOMAIN_TAG,)


Line 279:             lvm.activateLVs(self.VG_NAME, [self.LV_NAME])
Line 280:             lv = lvm.getLV(self.VG_NAME, self.LV_NAME)
Line 281:             self.assertTrue(lv.active)
Line 282:             self.assertEqual('a', lv.attr.state)
Line 283:             self.assertTrue(os.path.exists(lv_path))
> test the fake file size.
Done
Line 284: 
Line 285:     def test_changevgtags(self):
Line 286:         with self.base_config() as lvm:
Line 287:             deltags = (blockSD.STORAGE_UNREADY_DOMAIN_TAG,)


-- 
To view, visit https://gerrit.ovirt.org/56169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia364588a9fbe3a987b9117522db025e92c8ed296
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list