Change in vdsm[master]: migration: validate progress fields from libvirt

fromani at redhat.com fromani at redhat.com
Wed Apr 20 16:01:27 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: migration: validate progress fields from libvirt
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/56378/2//COMMIT_MSG
Commit Message:

Line 12: use are supposed to be unsigned integer, but up until
Line 13: now we blindly trust this.
Line 14: 
Line 15: This patch adds validation to make sure we don't receive
Line 16: negative data. Should this happen, we raise ValueError.
> I'm not sure about exact motivation of this change. Maybe you could add her
Will improve the commit message. As for the rationale for this patch, Martin reviewing https://gerrit.ovirt.org/#/c/56313/6 felt we should not trust libvirt too much.

I'm not 100% convinced we should have this protection, here's why I posted it separately.
Line 17: 
Line 18: Change-Id: I6de262ce30f32e908a65d5d44fe8499f6951aa63


https://gerrit.ovirt.org/#/c/56378/2/tests/vmMigrationTests.py
File tests/vmMigrationTests.py:

Line 169:     libvirt.VIR_DOMAIN_JOB_MEMORY_BPS: 128,
Line 170:     libvirt.VIR_DOMAIN_JOB_MEMORY_CONSTANT: 0,
Line 171:     libvirt.VIR_DOMAIN_JOB_COMPRESSION_BYTES: 0,
Line 172: }
Line 173: # workaround limitation of @permutations
> What limitation?
I can't use a list comprehension directly in @permutations.
Or, to be exact, I failed last time I tried.
Will try again, and update the comment to make it less cryptic.
Line 174: _JOB_DETAILS_KEYS = [[key] for key in _JOB_DETAILS]
Line 175: 
Line 176: 
Line 177: @expandPermutations


-- 
To view, visit https://gerrit.ovirt.org/56378
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6de262ce30f32e908a65d5d44fe8499f6951aa63
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list