Change in vdsm[master]: VolumeMetadata: Add from_lines factory method

alitke at redhat.com alitke at redhat.com
Wed Apr 20 15:48:21 UTC 2016


Adam Litke has posted comments on this change.

Change subject: VolumeMetadata: Add from_lines factory method
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/52672/3/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 176:         IMAGE:  'img_id',
Line 177:         PUUID:  'parent_vol_id',
Line 178:         SIZE:   'size',
Line 179:         FORMAT: 'vol_format',
Line 180:         TYPE:   'prealloc',
change to alloc_policy.
Line 181:         VOLTYPE: 'vol_type',
Line 182:         DISKTYPE: 'disk_type',
Line 183:         DESCRIPTION: 'description',
Line 184:         LEGALITY: 'legality',


Line 184:         LEGALITY: 'legality',
Line 185:         CTIME: 'ctime',
Line 186:         MTIME: 'mtime',
Line 187:     }
Line 188:     INT_KEYS = [SIZE, CTIME, MTIME]
merge this back into above struct.
Line 189: 
Line 190:     log = logging.getLogger('Storage.VolumeMetadata')
Line 191: 
Line 192:     def __init__(self, sd_id, img_id, parent_vol_id, size, vol_format,


-- 
To view, visit https://gerrit.ovirt.org/52672
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7f63dce8e42e99d3240f4e916a9bd6ee5ee4b61
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list