Change in vdsm[master]: net: add Transaction() to netconfpersistence

phoracek at redhat.com phoracek at redhat.com
Wed Apr 20 10:22:52 UTC 2016


Petr Horáček has posted comments on this change.

Change subject: net: add Transaction() to netconfpersistence
......................................................................


Patch Set 8: Verified+1

(3 comments)

Passed conf_persistence_test.py.

https://gerrit.ovirt.org/#/c/56149/7/lib/vdsm/netconfpersistence.py
File lib/vdsm/netconfpersistence.py:

PS7, Line 231: retur
> return
Done


https://gerrit.ovirt.org/#/c/56149/7/tests/network/conf_persistence_test.py
File tests/network/conf_persistence_test.py:

PS7, Line 51: _create_netconf():
> nit: _create_netconf
Done


Line 134: 
Line 135:     def tearDown(self):
Line 136:         rmtree(self.tempdir)
Line 137: 
Line 138:     def test_successful_setup(self):
> You can move now:
only Config, Transaction has variable params
Line 139:         with Transaction(config=self.config) as _config:
Line 140:             _config.setNetwork(NETWORK, NETWORK_ATTRIBUTES)
Line 141: 
Line 142:         file_path = os.path.join(self.tempdir, 'nets', NETWORK)


-- 
To view, visit https://gerrit.ovirt.org/56149
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab1dcf346a5d5de15f01148a58abc4ae6e0ab97d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list