Change in vdsm[master]: NetworkManager: configure to monitor ifcfg files

osvoboda at redhat.com osvoboda at redhat.com
Wed Apr 20 07:44:58 UTC 2016


Ondřej Svoboda has posted comments on this change.

Change subject: NetworkManager: configure to monitor ifcfg files
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/56365/1//COMMIT_MSG
Commit Message:

Line 19: This functionality is required to properly let NetworkManager
Line 20: know when VDSM consumes any of its devices (on ifcfg systems,
Line 21: by writing NM_CONTROLLED=no to an ifcfg file).
Line 22: 
Line 23: TODO: NetworkManager must be restarted after installing
> you can do that in the spec file's %post script: if you upgrade from a vdsm
Thank you, Dan, I'll use this logic.

Since there is a manual way to leave NetworkManager enabled, I think it makes sense to have this configuration now.
Line 24: the new configuration file.
Line 25: 
Line 26: Change-Id: I3eb80b3a280abd72c7084860467aca12907d0477
Line 27: Bug-Url: https://bugzilla.redhat.com/1304509


-- 
To view, visit https://gerrit.ovirt.org/56365
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3eb80b3a280abd72c7084860467aca12907d0477
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list