Change in vdsm[master]: net: OVS driver

edwardh at redhat.com edwardh at redhat.com
Tue Apr 19 19:09:38 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: OVS driver
......................................................................


Patch Set 9:

(2 comments)

https://gerrit.ovirt.org/#/c/55958/9/lib/vdsm/network/ovs/driver/__init__.py
File lib/vdsm/network/ovs/driver/__init__.py:

PS9, Line 130: set_db_entry
Can you move this up so the abstract methods will be on top and below them we'll have all the proxies (we will probably have more with time)


https://gerrit.ovirt.org/#/c/55958/9/lib/vdsm/network/ovs/driver/vsctl.py
File lib/vdsm/network/ovs/driver/vsctl.py:

Line 92: class CommandResultDB(Command):
Line 93: 
Line 94:     @Command.result.setter
Line 95:     def result(self, data):
Line 96:         # If check_error=False, run_vsctl can return None
> this is not here anymore
The comment should be dropped
Line 97:         if not data:
Line 98:             self._result = None
Line 99:             return
Line 100: 


-- 
To view, visit https://gerrit.ovirt.org/55958
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic24a9cea8d50e801de12da1c9cfcd2d195aed684
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list