Change in vdsm[master]: hostdev: get is_assignable from libvirt when available

fromani at redhat.com fromani at redhat.com
Tue Apr 19 14:01:47 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: hostdev: get is_assignable from libvirt when available
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

seems ok, even though wasteful (doing twice the same work) -1 for visibility

https://gerrit.ovirt.org/#/c/56299/1/lib/vdsm/hostdev.py
File lib/vdsm/hostdev.py:

PS1, Line 192: params['is_assignable'] = is_assignable
so we always override what we learned in line 155 above, possibly doing twice the same work?


-- 
To view, visit https://gerrit.ovirt.org/56299
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80560c0202a494afd15795156d618104b644c4de
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list