Change in vdsm[master]: vm: conf: proper locking in setNumberOfCpus()

mpolednik at redhat.com mpolednik at redhat.com
Tue Apr 19 12:15:22 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: vm: conf: proper locking in setNumberOfCpus()
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

question inside (CI related)

https://gerrit.ovirt.org/#/c/54910/6/tests/vmOperationsTests.py
File tests/vmOperationsTests.py:

PS6, Line 299: @permutations([[1], [2], [4], [16]])
             :     def testSetNumberOfVcpus(self, smp):
looking at testSetNumberOfVcpusFailed, don't we need similar protection for CI?


-- 
To view, visit https://gerrit.ovirt.org/54910
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20822e31af1e7350833d9c3080efc5d0f79a5cbe
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list