Change in vdsm[master]: tests/functional: Remove storage tests references from virtT...

mpolednik at redhat.com mpolednik at redhat.com
Tue Apr 19 07:15:43 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: tests/functional: Remove storage tests references from virtTests
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Few leftovers spotted. Otherwise fine patch.

https://gerrit.ovirt.org/#/c/55983/1/tests/functional/virtTests.py
File tests/functional/virtTests.py:

PS1, Line 319: 'hotplugDisk': {'vmId': customization['vmId']}}
Doesn't make sense to keep it.


PS1, Line 348: if 'hotplugDisk' in devices:
             :                 self.retryAssert(partial(self.vdsm.hotplugDisk,
             :                                          deviceDef['hotplugDisk']), timeout=10)
             :                 self.retryAssert(partial(self.vdsm.hotunplugDisk,
             :                                          deviceDef['hotplugDisk']), timeout=10)
Same.


-- 
To view, visit https://gerrit.ovirt.org/55983
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e3e499c51cb20fb2cc583afb88744aa90ced7a8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list