Change in vdsm[master]: client: do not protect requests on client side

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Mon Apr 18 19:09:43 UTC 2016


Piotr Kliczewski has posted comments on this change.

Change subject: client: do not protect requests on client side
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/56288/1//COMMIT_MSG
Commit Message:

Line 7: client: do not protect requests on client side
Line 8: 
Line 9: We need to keep message content without any changes before sending it to
Line 10: the server. If we won't json parser fails with:
Line 11: 
> the solution should be not to parse this value ... not to send passwords as
It was created to not to log passwords. We need to send a password over the wire for vdsm to use it.
What do you suggest to do?
Line 12: TypeError: '********' is not JSON serializable
Line 13: 
Line 14: 
Line 15: Change-Id: I197591fbf0fb42647267b6901998324dd02a8080


-- 
To view, visit https://gerrit.ovirt.org/56288
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I197591fbf0fb42647267b6901998324dd02a8080
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list