Change in vdsm[master]: asyncore: make sure to handle sslerror on send

danken at redhat.com danken at redhat.com
Mon Apr 18 15:18:53 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: asyncore: make sure to handle sslerror on send
......................................................................


asyncore: make sure to handle sslerror on send

When we receive data we handle ssl errors in cases like a client
disconections. We want to make sure that we close connection and return
to message processing code to handle the issue.

In send we have similar behavior but the error propagates to asyncore
loop where it is handled. For send we need to have similar behavior:
- close channel
- let the sender code handle case where no data was send


Change-Id: I28fd1accb04c74c8ed2f11ba47fa5ef7fee67883
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
Reviewed-on: https://gerrit.ovirt.org/56206
Continuous-Integration: Jenkins CI
Tested-by: Simone Tiraboschi <stirabos at redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/yajsonrpc/betterAsyncore.py
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Simone Tiraboschi: Verified
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/56206
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I28fd1accb04c74c8ed2f11ba47fa5ef7fee67883
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list