Change in vdsm[master]: hostdev: add is_assignable flag

mpolednik at redhat.com mpolednik at redhat.com
Mon Apr 18 14:12:30 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: hostdev: add is_assignable flag
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/56291/2/lib/vdsm/hostdev.py
File lib/vdsm/hostdev.py:

PS2, Line 155: not _pci_header_type(name)
> I prefer '_pci_header_type(name) == 0' for clarity. Or you con go another s
possibly yeah, btw the direction is shifted a bit if you look at v3 (https://www.redhat.com/archives/libvir-list/2016-March/msg00783.html) -- unfortunately in a direction that is worse for us


-- 
To view, visit https://gerrit.ovirt.org/56291
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6fd0d39e777c6bc0f3175b737ace9be92df4cca0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list