Change in vdsm[master]: migration: Add Dynamic Bounded Semaphores

fromani at redhat.com fromani at redhat.com
Mon Apr 18 13:52:58 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: migration: Add Dynamic Bounded Semaphores
......................................................................


Patch Set 23: Code-Review+1

(4 comments)

nitpicking in the tests is not good enough reason to delay my +1.
Please check the inline comment to get my +2

https://gerrit.ovirt.org/#/c/53304/23/tests/vmUtilsTests.py
File tests/vmUtilsTests.py:

Line 197:         self.assertAcquirable(times=added_capacity)
Line 198:         self.assertNotAcquirable()
Line 199: 
Line 200:     def test_bound_decrease_while_acquired(self):
Line 201:         self.assertAcquirable(times=3)
I guess you can use INITIAL_BOUND also here, right?
Line 202:         self.sem.bound = 4
Line 203:         self.assertAcquirable()
Line 204:         self.assertNotAcquirable()
Line 205: 


PS23, Line 201:         self.assertAcquirable(times=3)
              :         self.sem.bound = 4
(INITIAL_BOUND + 1) ?


PS23, Line 207:         self.assertAcquirable(times=3)
same, you could most likely use INITIAL_BOUND here


PS23, Line 208:         self.sem.bound = 1
here 1 is fine


-- 
To view, visit https://gerrit.ovirt.org/53304
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67376d0bd990f89e0a013887cef1a0cb05fb855d
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list