Change in vdsm[master]: Let the engine control the guest lifecycle events

fromani at redhat.com fromani at redhat.com
Mon Apr 18 12:21:13 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: Let the engine control the guest lifecycle events
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/56286/1/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 265:                 self.log.exception("Failed to destroy remote VM")
Line 266:         # if the guest was stopped before migration, we need to cont it
Line 267:         if self.hibernating:
Line 268:             self._vm.cont()
Line 269:             if self._enableGuestEvents:
instead of adding if()s all around, could be worth to move this check inside the GuestAgentEvents class. What do you think about this?
Line 270:                 self._vm.guestAgent.events.after_hibernation_failure()
Line 271:         elif self._enableGuestEvents:
Line 272:             self._vm.guestAgent.events.after_migration_failure()
Line 273:         # either way, migration has finished


-- 
To view, visit https://gerrit.ovirt.org/56286
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b78489169260ed53420a3b3fda33a0cc917d66c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list