Change in vdsm[ovirt-3.6]: host stats: Collect stats from online cpu cores only

nsoffer at redhat.com nsoffer at redhat.com
Fri Apr 15 22:29:50 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: host stats: Collect stats from online cpu cores only
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.ovirt.org/#/c/56188/1/tests/samplingTests.py
File tests/samplingTests.py:

Line 26
Line 27
Line 28
Line 29
Line 30
six not used now in this module?


Line 321: 
Line 322:         with MonkeyPatchScope([(sampling, 'HostSample', FakeHostSample)]):
Line 323:             self._hs = sampling.HostStatsThread(self.log)
Line 324:             self._hs._sampleInterval = 0
Line 325:             # we cannot monkey patch, it will interfere on threading internals
Is this related?
Line 326:             self._hs._stopEvent = FakeEvent()
Line 327:             self._hs.start()
Line 328:             self._hs.join()
Line 329:             first, last, _ = self._hs._samples.stats()


https://gerrit.ovirt.org/#/c/56188/1/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:

Line 55:     A network interface sample.
Line 56: 
Line 57:     The sample is set at the time of initialization and can't be updated.
Line 58:     """
Line 59: 
I like this whitespace, but it seems unrelated.
Line 60:     def readIfaceStat(self, ifid, stat):
Line 61:         """
Line 62:         Get and interface's stat.
Line 63: 


-- 
To view, visit https://gerrit.ovirt.org/56188
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9c247f9138e02a9230a0849a04cb2e1705e7fac
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list