Change in vdsm[master]: tests: Add test_missing_tags for block storage

nsoffer at redhat.com nsoffer at redhat.com
Fri Apr 15 21:47:11 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: tests: Add test_missing_tags for block storage
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Test looks ok, but I want to remove these data files instead of adding new files, and this test is not testing lvm instead of blockSD.

https://gerrit.ovirt.org/#/c/56171/2/tests/blocksdTests.py
File tests/blocksdTests.py:

Line 65
Line 66
Line 67
Line 68
Line 69
Why not return fake lv instead of reading lvm output? This tests lvm module, not blockSD.

And now we have to keep more test data files, and mention them in makefiles etc. Why work hard when we have easier way?


-- 
To view, visit https://gerrit.ovirt.org/56171
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb789cf146a4a9919e4dc864a0ae744e06510cec
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list