Change in vdsm[master]: macspoof hook: README: help adding the custom property

edwardh at redhat.com edwardh at redhat.com
Fri Apr 15 18:42:59 UTC 2016


Edward Haas has posted comments on this change.

Change subject: macspoof hook: README: help adding the custom property
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/56015/1/vdsm_hooks/macspoof/README
File vdsm_hooks/macspoof/README:

PS1, Line 13: somthing_you_had_before=regexp;
It took me a while to understand that this is for documentation only.
I usually would just copy-paste this line.

What about explaining this outside of the actual command?


-- 
To view, visit https://gerrit.ovirt.org/56015
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7edb61612d5af913ec34d6077a0fa49fcc6ce63
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list