Change in vdsm[master]: virt: fixes for pep8 1.6.x

fromani at redhat.com fromani at redhat.com
Thu Apr 14 16:30:57 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: fixes for pep8 1.6.x
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/56084/3/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:

Line 109:                 # verify that the cached path is the one used in libvirt.
Line 110:                 # We already hit few times the problem that after a live
Line 111:                 # migration the paths were not in sync anymore (BZ#1059482).
Line 112:                 if (hasattr(d, 'alias') and d.alias == alias and
Line 113:                    d.path != devPath):
> This is accepted by pep8?!
Indented like you suggested (which was my first choice btw):

[fromani at fedrkt vdsm]$ pep8 --version
1.6.2
[fromani at fedrkt vdsm]$ pep8 vdsm/virt/vmdevices/storage.py 
vdsm/virt/vmdevices/storage.py:113:5: E129 visually indented line with same indent as next logical line

however, if indent another level, so the source code ends up like

if (hasattr(d, 'alias') and d.alias == alias and
        d.path != devPath):

pep8 doesn't complain.
Line 114:                     vm.log.warning('updating drive %s path from %s to %s',
Line 115:                                    d.alias, d.path, devPath)
Line 116:                     d.path = devPath
Line 117:                 if d.path == devPath:


-- 
To view, visit https://gerrit.ovirt.org/56084
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e06319d0be2cc927ecd3f2bf15f0688bdac11dc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list