Change in vdsm[master]: configure: add support for nosetests/python 3.5

fromani at redhat.com fromani at redhat.com
Thu Apr 14 16:20:48 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: configure: add support for nosetests/python 3.5
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/56083/3/configure.ac
File configure.ac:

Line 289:   fi
Line 290: 
Line 291:   AC_PATH_PROG([PYTHON3_NOSE], [nosetests-3.4])
Line 292:   if test "x$PYTHON3_NOSE" = "x"; then
Line 293:     AC_PATH_PROG([PYTHON3_NOSE], [nosetests-3.5])
> This is crazy, why should we care about python 3.4 and 3.5? python3 should 
I agree, the correct fix is to check if python3 can import nose.
Line 294:   fi
Line 295:   if test "x$PYTHON3_NOSE" = "x"; then
Line 296:     AC_MSG_ERROR([python3-nose not found])
Line 297:   fi


-- 
To view, visit https://gerrit.ovirt.org/56083
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d5f0a8545ff0d3f3071a58f327a61892a57a71a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list