Change in vdsm[master]: hsm: add untrusted image verification.

nsoffer at redhat.com nsoffer at redhat.com
Thu Apr 14 16:18:26 UTC 2016


Nir Soffer has submitted this change and it was merged.

Change subject: hsm: add untrusted image verification.
......................................................................


hsm: add untrusted image verification.

In some flows, where an image can be imported into oVirt's storage from
external sources, e.g in the image upload flow- a VDSM's image is being
generated and data is being sent into the created volume inside.

As this flow is risky in cases where the data is a QCOW file with an
invalid backing file, or wrong disk format is sent, VDSM should verify
the image in the upload process.

This patch adds a verb for untrusted image's volume verification, which
verifies that there is no backing file for a QCOW image, and that the
format of the uploaded image fits to what the user has specified.

Change-Id: Ibf85061536eb4ddff021539c742a674f183a8984
Signed-off-by: Amit Aviram <aaviram at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/55746
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Continuous-Integration: Jenkins CI
---
M lib/api/vdsmapi-schema.json
M lib/vdsm/storage/exception.py
M vdsm/API.py
M vdsm/storage/hsm.py
4 files changed, 57 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Amit Aviram: Verified



-- 
To view, visit https://gerrit.ovirt.org/55746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf85061536eb4ddff021539c742a674f183a8984
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list