Change in vdsm[master]: storage: readspeed: drop useless return value

nsoffer at redhat.com nsoffer at redhat.com
Thu Apr 14 16:01:23 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: storage: readspeed: drop useless return value
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/56160/1/vdsm/storage/misc.py
File vdsm/storage/misc.py:

Line 187
Line 188
Line 189
Line 190
Line 191
Please remove the group, we are not interested in capturing it.


Line 193:     "([\de\-.]+|Infinity) [kMGT]*B/s"
Line 194: )
Line 195: 
Line 196: 
Line 197: def read_delay(path, buffersize=None):
This function is going to be removed, don't rename it, and it is also not related to the real change.
Line 198:     """
Line 199:     Measures the amount of bytes transferred and the time elapsed
Line 200:     reading the content of the file/device
Line 201:     """


-- 
To view, visit https://gerrit.ovirt.org/56160
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22cc27a04603e8f53c5103283c3b4d64a4fabcec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list