Change in vdsm[master]: storage: support new dd output

nsoffer at redhat.com nsoffer at redhat.com
Thu Apr 14 14:36:57 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: storage: support new dd output
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/56091/1/vdsm/storage/misc.py
File vdsm/storage/misc.py:

Line 188:     return str(ctime)
Line 189: 
Line 190: _readspeed_regex = re.compile(
Line 191:     "(?P<bytes>\d+) bytes?"
Line 192:     "(|( \([\de\-.]+ [kMGT]*B(|, [\de\-.]+ [KMGT]*iB)\))) copied, "
> OK, do you want me to simplify the regex first then (perhaps?) replace it w
I would do this:

- drop the parsing of the unneeded bytes value and the return value.
- add failing tests for the new human readable format
- simplify parsing so we are not effected by new the human readable format, fixing the broken tests.

Note that this code and the tests are removed and replaced by https://gerrit.ovirt.org/#/c/54757/34/tests/storage_check_test.py

I want to merge that patch soon.
Line 193:     "(?P<seconds>[\de\-.]+) s, "
Line 194:     "([\de\-.]+|Infinity) [kMGT]*B/s"
Line 195: )
Line 196: 


-- 
To view, visit https://gerrit.ovirt.org/56091
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I632d99cdc2b41e96a75bdce12e86710241fa0939
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list