Change in vdsm[master]: build: Make sure run_tests*.sh scripts are executable

ybronhei at redhat.com ybronhei at redhat.com
Thu Apr 14 08:31:53 UTC 2016


Yaniv Bronhaim has posted comments on this change.

Change subject: build: Make sure run_tests*.sh scripts are executable
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/55949/1/build-aux/Makefile.subs
File build-aux/Makefile.subs:

Line 38: 
Line 39: CONFIGSUBST = $(top_builddir)/config.status --file=-
Line 40: 
Line 41: %.sh: %.sh.in
Line 42: 	@echo "  SED $@"; $(PATHSUBST) $< |$(CONFIGSUBST) >$@
> Only the first rule is invoked for *.sh files. If you ask about code duplic
maybe you should have specific rules for this 2 scripts in tests/Makefile.am - try to do that there. I think the duplication of the .in rules make the wrong paths bug that you face
Line 43: 	chmod +x $@
Line 44: 
Line 45: %: %.in


-- 
To view, visit https://gerrit.ovirt.org/55949
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1e3dc8ace7f69801b765262352903020cc8aef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list