Change in vdsm[master]: hsm: add untrusted image verification.

aaviram at redhat.com aaviram at redhat.com
Thu Apr 14 07:12:10 UTC 2016


Amit Aviram has posted comments on this change.

Change subject: hsm: add untrusted image verification.
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/55746/7/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 8300: # comparing the untrusted volume's format with the format that is specified
Line 8301: # in the volume's metadata, and if the format is QCOW, verifying that
Line 8302: # it has no backingfile.
Line 8303: # If one of the verifications above fails, an
Line 8304: # ImageVerificationError will be returned.
> Which test fail? sounds like broken test to me.
It is "process-schema.py" that fail:

PYTHONDONTWRITEBYTECODE=1 PYTHONPATH=./../lib \
    /usr/bin/python ./process-schema.py \
              ./vdsmapi-schema.json ./vdsm-api.html
Traceback (most recent call last):
  File "./process-schema.py", line 376, in <module>
    main()
  File "./process-schema.py", line 370, in main
    symbols = read_schema_doc(f, api)
  File "./process-schema.py", line 175, in read_schema_doc
    read_symbol_comment(f, api)
  File "./process-schema.py", line 156, in read_symbol_comment
    symbol[mode][last_arg] += ' ' + line
KeyError: None
Line 8305: #
Line 8306: # @storagepoolID:    The Storage Pool associated with the Volume
Line 8307: #
Line 8308: # @storagedomainID:  The Storage Domain associated with the Volume


-- 
To view, visit https://gerrit.ovirt.org/55746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf85061536eb4ddff021539c742a674f183a8984
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list