Change in vdsm[master]: mount: Log info message when mounting or unmounting

nsoffer at redhat.com nsoffer at redhat.com
Wed Apr 13 18:15:13 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: mount: Log info message when mounting or unmounting
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/43974/8/lib/vdsm/storage/mount.py
File lib/vdsm/storage/mount.py:

Line 198: 
Line 199: 
Line 200: class Mount(object):
Line 201: 
Line 202:     log = logging.getLogger("storage.Mount")
> I don't think there's much point in setting a special logger. You want the 
This is true for most logs :-)

I want this log to belong to the storage logger, and inherit its configuration, and this is the normal logging we do everywhere.

We need to clean up logging but this is not the time to do this.
Line 203: 
Line 204:     def __init__(self, fs_spec, fs_file):
Line 205:         self.fs_spec = normpath(fs_spec)
Line 206:         self.fs_file = normpath(fs_file)


-- 
To view, visit https://gerrit.ovirt.org/43974
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc89d6a1bfa0e9d117344d8870d81fed140d03c6
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list