Change in vdsm[master]: net: native ovs: validate networks and bonds

phoracek at redhat.com phoracek at redhat.com
Wed Apr 13 14:41:18 UTC 2016


Petr Horáček has posted comments on this change.

Change subject: net: native ovs: validate networks and bonds
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/55310/4/lib/vdsm/network/ovs/validator.py
File lib/vdsm/network/ovs/validator.py:

PS4, Line 53: else
> Why is that? I don't understand what is the difference.
Legacy vlan requires an underlying iface:

$ ip link add link eth0 name eth0.8 type vlan id 8

OVS vlan is a fake bridge and does not require a port.

I will add a comment.


-- 
To view, visit https://gerrit.ovirt.org/55310
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bceae0aada964c47aacfcfdbe93ca19eb8f3d14
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list