Change in vdsm[master]: sdm: create_volume: remove duplicated args check

nsoffer at redhat.com nsoffer at redhat.com
Wed Apr 13 13:44:50 UTC 2016


Nir Soffer has submitted this change and it was merged.

Change subject: sdm: create_volume: remove duplicated args check
......................................................................


sdm: create_volume: remove duplicated args check

We are already validating the create arguments inside
VolumeArtifacts.create where we can also validate the preallocate
parameter.  The call in create_volume is redundant and should be
removed.

Change-Id: I06d355212db5677324bfaa29d25afa3855cd300b
Signed-off-by: Adam Litke <alitke at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/56053
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Freddy Rolland <frolland at redhat.com>
---
M vdsm/storage/sdm/api/create_volume.py
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Adam Litke: Verified
  Jenkins CI: Passed CI tests
  Freddy Rolland: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/56053
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I06d355212db5677324bfaa29d25afa3855cd300b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list