Change in vdsm[master]: schema: SDM.create_volume split parent params

nsoffer at redhat.com nsoffer at redhat.com
Wed Apr 13 13:44:36 UTC 2016


Nir Soffer has submitted this change and it was merged.

Change subject: schema: SDM.create_volume split parent params
......................................................................


schema: SDM.create_volume split parent params

When creating a new volume, the parent_vol_id and parent_img_id are
optional and should be used only if the new volume is derived from a
parent (ie. snapshot volume or volume from template).  However, if one
of the parent_*_id parameters is specified the other one must also be
provided.  The best way to codify this and organize the create
parameters is to place the two parent ids together in their own data
structure.

Change-Id: I7ccaf88a122dec24fa8d018c0cd94b4a08ecadce
Signed-off-by: Adam Litke <alitke at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/55829
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Freddy Rolland <frolland at redhat.com>
---
M lib/api/vdsmapi-schema.json
1 file changed, 15 insertions(+), 7 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Nir Soffer: Looks good to me, approved
  Adam Litke: Verified
  Jenkins CI: Passed CI tests
  Freddy Rolland: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/55829
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7ccaf88a122dec24fa8d018c0cd94b4a08ecadce
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list