Change in vdsm[master]: net: native ovs: ovs switch skeleton

edwardh at redhat.com edwardh at redhat.com
Wed Apr 13 13:26:25 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: native ovs: ovs switch skeleton
......................................................................


Patch Set 15:

(1 comment)

https://gerrit.ovirt.org/#/c/55308/15/lib/vdsm/network/netswitch.py
File lib/vdsm/network/netswitch.py:

PS15, Line 64:         if 'remove' in attrs:
             :             running_switch = running_config_entries.get(name, {}).get('switch')
             :             store_entry(name, attrs, running_switch)
             :         else:
             :             store_entry(name, attrs, attrs['switch'])
You can do this:
if 'remove'...:
    conf_attrs = running_config_entries.get(name, {})
    switch_type = conf_attrs.get('switch')
else:
    switch_type = attrs['switch']
store_entry(name, attrs, switch_type)


-- 
To view, visit https://gerrit.ovirt.org/55308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic056fcf8c0d36625328a90a339d4a09658683056
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list