Change in vdsm[master]: build: Make sure run_tests*.sh scripts are executable

ybronhei at redhat.com ybronhei at redhat.com
Wed Apr 13 09:25:27 UTC 2016


Yaniv Bronhaim has posted comments on this change.

Change subject: build: Make sure run_tests*.sh scripts are executable
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/55949/1/configure.ac
File configure.ac:

Line 462
Line 463
Line 464
Line 465
Line 466
so basically your problem is that we do it in configure and not in make


https://gerrit.ovirt.org/#/c/55949/1/tests/Makefile.am
File tests/Makefile.am:

Line 192: 	other.csr \
Line 193: 	other.key
Line 194: 
Line 195: dist_noinst_SCRIPTS = \
Line 196: 	run_tests_local.sh
run_tests.sh should be here too. unless you don't want to clean those files at all with make clean and they will stay executable
Line 197: 
Line 198: dist_vdsmtests_DATA = \
Line 199: 	README \
Line 200: 	cpu_info.out \


-- 
To view, visit https://gerrit.ovirt.org/55949
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1e3dc8ace7f69801b765262352903020cc8aef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list