Change in vdsm[master]: sp.py: Assume a hostId when reconstructing master

nsoffer at redhat.com nsoffer at redhat.com
Tue Apr 12 20:02:25 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: sp.py: Assume a hostId when reconstructing master
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/55857/3/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 1843
Line 1844
Line 1845
Line 1846
Line 1847
According to the schema this is correct change, but the schema by be wrong about how engine call this.

This is risky change.


Line 1894:             raise se.StoragePoolConnected(spUUID)
Line 1895: 
Line 1896:         self.validateSdUUID(masterDom)
Line 1897: 
Line 1898:         misc.validateN(hostId, 'hostId')
I think this is the only change we need in this file.

We can delay the api changes to another patch.
Line 1899: 
Line 1900:         vars.task.getExclusiveLock(STORAGE, spUUID)
Line 1901: 
Line 1902:         for d, status in domDict.iteritems():


-- 
To view, visit https://gerrit.ovirt.org/55857
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaffbb563532a40f67f33fd971f55724e994c49dd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list