Change in vdsm[master]: sdm: Move create_volume parent uuids into separate type
nsoffer at redhat.com
nsoffer at redhat.com
Tue Apr 12 19:07:34 UTC 2016
Nir Soffer has posted comments on this change.
Change subject: sdm: Move create_volume parent uuids into separate type
......................................................................
Patch Set 5: Code-Review-1
(1 comment)
The tests are much nicer now, thanks!
https://gerrit.ovirt.org/#/c/55830/5/vdsm/storage/sdm/volume_artifacts.py
File vdsm/storage/sdm/volume_artifacts.py:
Line 201: if parent_vol_id != volume.BLANK_UUID:
Line 202: raise NotImplementedError("parent_vol_id not supported")
Line 203:
Line 204: if self.is_image() and parent_vol_id == volume.BLANK_UUID:
Line 205: raise se.InvalidParameterException("parent.vol_id", parent_vol_id)
Can we do instead:
if not parent:
raise
Or we are not sure:
if not parent or parent.vol_id == volume.BLANK_UUID:
raise
I prefer the simpler form, we don't want to support these hacks any more.
Line 206:
Line 207: prealloc = self._get_volume_preallocation(vol_format)
Line 208: self.sd_manifest.validateCreateVolumeParams(
Line 209: vol_format, parent_vol_id, preallocate=prealloc)
--
To view, visit https://gerrit.ovirt.org/55830
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81aa1be73cb66ef6ca00d5b6a1997defd9aa8a48
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list