Change in vdsm[master]: sdm: Move create_volume parent uuids into separate type

alitke at redhat.com alitke at redhat.com
Tue Apr 12 18:44:27 UTC 2016


Adam Litke has posted comments on this change.

Change subject: sdm: Move create_volume parent uuids into separate type
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/55830/3/tests/storage_sdm_create_volume_test.py
File tests/storage_sdm_create_volume_test.py:

Line 155: 
Line 156:     def test_default_parameter(self):
Line 157:         info = _get_vol_info()
Line 158:         del info['description']
Line 159:         del info['initial_size']
> Why do we delete these? why not create the default dict without them, and a
Done
Line 160: 
Line 161:         info_obj = storage.sdm.api.create_volume.CreateVolumeInfo(info)
Line 162:         self.assertEqual('', info_obj.description)
Line 163:         self.assertEqual(0, info_obj.initial_size)


Line 179:                           storage.sdm.api.create_volume.ParentVolumeInfo,
Line 180:                           {'vol_id': 'foo'})
Line 181:         self.assertRaises(exception.MissingParameter,
Line 182:                           storage.sdm.api.create_volume.ParentVolumeInfo,
Line 183:                           {'img_id': 'foo'})
> Better use permutations to test separately each case, will also remove 2/3 
Done
Line 184: 
Line 185:     def test_complete_params(self):
Line 186:         params = dict(vol_id='foo', img_id='bar')
Line 187:         obj = storage.sdm.api.create_volume.ParentVolumeInfo(params)


-- 
To view, visit https://gerrit.ovirt.org/55830
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81aa1be73cb66ef6ca00d5b6a1997defd9aa8a48
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list