Change in vdsm[master]: sdm: create_volume: remove duplicated args check

nsoffer at redhat.com nsoffer at redhat.com
Tue Apr 12 17:39:11 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: sdm: create_volume: remove duplicated args check
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/56053/2//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: We are already validating the create arguments inside
Line 10: VolumeArtifacts.create where we can also validate the preallocate
Line 11: parameter.  The call in create_volume is redundant and should be
Line 12: removed.
Validation should be done early - why not move the validation to the create volume job instead of volume artifacts?
Line 13: 
Line 14: Change-Id: I06d355212db5677324bfaa29d25afa3855cd300b


-- 
To view, visit https://gerrit.ovirt.org/56053
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06d355212db5677324bfaa29d25afa3855cd300b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list