Change in vdsm[master]: hostdev: expose generic scsi driver char device in device pa...
fromani at redhat.com
fromani at redhat.com
Tue Apr 12 14:52:11 UTC 2016
Francesco Romani has posted comments on this change.
Change subject: hostdev: expose generic scsi driver char device in device params
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/55022/3/lib/vdsm/hostdev.py
File lib/vdsm/hostdev.py:
PS3, Line 167: try:
: udev_path = caps.find('char').text
: except AttributeError:
: # Is not scsi char device.
: pass
: else:
: params['udev_path'] = udev_path
this works. I think it is a bit clearer if we do:
char_node = caps.find('char')
if char_node is not None:
params['udev_path'] = char_node.text
(feel free to rename char_node to udev_path or whatever)
--
To view, visit https://gerrit.ovirt.org/55022
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91e6793e946310b57e3004cbebc286cc6e00a724
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list