Change in vdsm[master]: jsonrpc: make sure not to block when processing i/o

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Tue Apr 12 13:20:06 UTC 2016


Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpc: make sure not to block when processing i/o
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/55872/4/lib/vdsm/protocoldetector.py
File lib/vdsm/protocoldetector.py:

Line 120
Line 121
Line 122
Line 123
Line 124
> This change is wrong as well, protocol detector does not know and should no
Having it here was done under wrong assumption that xmlrpc needs blocking socket.


-- 
To view, visit https://gerrit.ovirt.org/55872
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dee39c7ec518721e809de1cb542173161612ffb
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list