Change in vdsm[master]: jsonrpc: make sure not to block when processing i/o

danken at redhat.com danken at redhat.com
Tue Apr 12 09:02:23 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: jsonrpc: make sure not to block when processing i/o
......................................................................


Patch Set 2:

this using non-blocking sockets requires a more descriptive commit message. why do we need this? wouldn't it break other users of create_connected_socket (namely migration)?

-- 
To view, visit https://gerrit.ovirt.org/55872
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dee39c7ec518721e809de1cb542173161612ffb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list