Change in vdsm[master]: virt: storage: avoid empty serials to domain XML

nsoffer at redhat.com nsoffer at redhat.com
Tue Apr 12 08:31:24 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: virt: storage: avoid empty serials to domain XML
......................................................................


Patch Set 2:

(5 comments)

https://gerrit.ovirt.org/#/c/56014/2/tests/vmStorageTests.py
File tests/vmStorageTests.py:

Line 156
Line 157
Line 158
Line 159
Line 160
Add the serial here for tests that require a serial. serial is optional, the tests should treat is as such.


Line 566
Line 567
Line 568
Line 569
Line 570
Let callers add serial="xxx" when they want a serial.


Line 568
Line 569
Line 570
Line 571
Line 572
This should contain only required attribute that all tests need.


Line 194:             """
Line 195:         self.check({}, conf, xml, is_block_device=False)
Line 196: 
Line 197:     def test_disk_without_serial(self):
Line 198:         conf = drive_config(serial=None)
To have no serial, don't call with a serial kwarg
Line 199:         xml = """
Line 200:             <disk device="disk" snapshot="no" type="file">
Line 201:                 <source file="/path/to/volume"/>
Line 202:                 <target bus="virtio" dev="vda"/>


Line 614:     conf.update(kw)
Line 615:     return conf
Line 616: 
Line 617: 
Line 618: def add_serial(conf, serial):
why so complicated?
Line 619:     if serial is not None:
Line 620:         if serial == '':
Line 621:             conf['serial'] = '54-a672-23e5b495a9ea'
Line 622:         else:


-- 
To view, visit https://gerrit.ovirt.org/56014
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I175954321faef8fb33ee31b6b367bfad9ec87137
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list