Change in vdsm[master]: virt: add device setup and teardown

nsoffer at redhat.com nsoffer at redhat.com
Tue Apr 12 08:26:12 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: virt: add device setup and teardown
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/55135/7/tests/vmTests.py
File tests/vmTests.py:

Line 1136: 
Line 1137:         with fake.VM(self.conf, create_device_objects=True) as testvm:
Line 1138:             testvm._devices[hwclass.GENERAL] = devices
Line 1139:             self.assertRaises(Exception, testvm._setup_devices)
Line 1140:             self.assertDeviceCalls(devices, expected_calls)
> That is how it works (except for "original error" as it's the first error?)
Yes the first error during setup should be raised as it is usually the most interesting.
Line 1141: 
Line 1142:     def test_device_teardown_success(self):
Line 1143:         devices = [fake.Device() for _ in range(3)]
Line 1144:         expected_calls = [[('teardown', (), {})],


-- 
To view, visit https://gerrit.ovirt.org/55135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list