Change in vdsm[master]: hsm: add untrusted image verification.

nsoffer at redhat.com nsoffer at redhat.com
Tue Apr 12 08:24:08 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: hsm: add untrusted image verification.
......................................................................


Patch Set 6:

(5 comments)

Code looks good, schema needs little cleanups.

https://gerrit.ovirt.org/#/c/55746/6/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 8293: ##
Line 8294: # @Volume.verify_untrusted:
Line 8295: #
Line 8296: # Verify an untrusted image's volume. The verification includes comparing
Line 8297: # the uploaded image's format with the format that is specified in the
Remove "uploaded".

Please explain in the first sentence what is untrusted image, with example of uploaded image.

Also, this verify a volume not an image, remove the word "image".
Line 8298: # image's volume's metadata, and if the format is QCOW, verifying that
Line 8299: # it has no backingfile. if one of the verifications above fails, an
Line 8300: # error will be raised.
Line 8301: # An untrusted volume can be one which is uploaded by oVirt's user, or


Line 8294: # @Volume.verify_untrusted:
Line 8295: #
Line 8296: # Verify an untrusted image's volume. The verification includes comparing
Line 8297: # the uploaded image's format with the format that is specified in the
Line 8298: # image's volume's metadata, and if the format is QCOW, verifying that
image's volume's -> volume's
Line 8299: # it has no backingfile. if one of the verifications above fails, an
Line 8300: # error will be raised.
Line 8301: # An untrusted volume can be one which is uploaded by oVirt's user, or
Line 8302: # taken from an external source.


Line 8296: # Verify an untrusted image's volume. The verification includes comparing
Line 8297: # the uploaded image's format with the format that is specified in the
Line 8298: # image's volume's metadata, and if the format is QCOW, verifying that
Line 8299: # it has no backingfile. if one of the verifications above fails, an
Line 8300: # error will be raised.
we don't raise errors, re return an error response - and specify the error name.
Line 8301: # An untrusted volume can be one which is uploaded by oVirt's user, or
Line 8302: # taken from an external source.
Line 8303: #
Line 8304: # @storagepoolID:    The Storage Pool associated with the Volume


Line 8297: # the uploaded image's format with the format that is specified in the
Line 8298: # image's volume's metadata, and if the format is QCOW, verifying that
Line 8299: # it has no backingfile. if one of the verifications above fails, an
Line 8300: # error will be raised.
Line 8301: # An untrusted volume can be one which is uploaded by oVirt's user, or
can be -> is
Line 8302: # taken from an external source.
Line 8303: #
Line 8304: # @storagepoolID:    The Storage Pool associated with the Volume
Line 8305: #


Line 8298: # image's volume's metadata, and if the format is QCOW, verifying that
Line 8299: # it has no backingfile. if one of the verifications above fails, an
Line 8300: # error will be raised.
Line 8301: # An untrusted volume can be one which is uploaded by oVirt's user, or
Line 8302: # taken from an external source.
This should be the first sentence. I would rephrase it like this:

    An untrusted volume is a volume that was in control of a user or untrusted
    external program, and may contain malicious data. One example is a volume
    uploaded by a user using ovirt-imageio.
Line 8303: #
Line 8304: # @storagepoolID:    The Storage Pool associated with the Volume
Line 8305: #
Line 8306: # @storagedomainID:  The Storage Domain associated with the Volume


-- 
To view, visit https://gerrit.ovirt.org/55746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf85061536eb4ddff021539c742a674f183a8984
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list