Change in vdsm[master]: migration: added logging of more detailed stats

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Tue Apr 12 08:18:53 UTC 2016


Michal Skrivanek has posted comments on this change.

Change subject: migration: added logging of more detailed stats
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/55976/2/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 613: 
Line 614:                 self._vm.log.info('Migration Progress: %s seconds elapsed,'
Line 615:                                   ' %s%% of data processed, total data: %ibytes,'
Line 616:                                   'processed data: %ibytes, remaining data: %ibytes,'
Line 617:                                   'transfer speed %ibps, constant memory transferred: %i pages,'
how about more concise string:
, total x, processed y, remaining z, speed x. zero pages: y, compressed: z
Line 618:                                   'transferred compressed data: %ibytes' %
Line 619:                                   (timeElapsed / 1000, self.progress), dataTotal, dataProcessed, dataRemaining, memBps,
Line 620:                                   memConstant, compressionBytes)
Line 621: 


Line 653: 
Line 654:     def _extract_stats(self):
Line 655:         stats = self._vm._dom.jobStats()
Line 656: 
Line 657:         return (stats['type'], stats[libvirt.VIR_DOMAIN_JOB_TIME_ELAPSED], stats[libvirt.VIR_DOMAIN_JOB_DATA_TOTAL],
if we can somehow retrieve libvirt 1.3 stats as well that would be awesome
Line 658:                 stats[libvirt.VIR_DOMAIN_JOB_DATA_PROCESSED], stats[libvirt.VIR_DOMAIN_JOB_DATA_REMAINING],
Line 659:                 stats[libvirt.VIR_DOMAIN_JOB_MEMORY_TOTAL], stats[libvirt.VIR_DOMAIN_JOB_MEMORY_PROCESSED],
Line 660:                 stats[libvirt.VIR_DOMAIN_JOB_MEMORY_REMAINING], stats[libvirt.VIR_DOMAIN_JOB_MEMORY_BPS],


-- 
To view, visit https://gerrit.ovirt.org/55976
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0b81c77b62e52190bfb9fe857105389d75d11e4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list