Change in vdsm[master]: migration: Add retry on full capacity

fromani at redhat.com fromani at redhat.com
Mon Apr 11 15:30:56 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: migration: Add retry on full capacity
......................................................................


Patch Set 27: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/52799/27/vdsm/virt/migration.py
File vdsm/virt/migration.py:

PS27, Line 332: while self._progress < 100:
> That seems to me as a less safe and slightly less obvious alternative. If y
The semantic we need here is "while not completed", like the boolean Martin added into a previous upload. The error paths should be covered using exceptions, so we are ok with them. In the success path, I'm not completely happy with neither approaches.

If we check for vm being down, we could indeed have errors inside finishSuccesfully that could trigger another migration attempt. But in the case the migration will be already completed from the libvirt perspective, so I'm not sure about the outcome - I just expect another failure.

I'm not sure checking _progress is really the most future proof approach (I'm suspecting it is not), but still seems the safest way if we don't want to add another boolean, and at this stage I prefer not to.

So let's go with _progress.


-- 
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988fa2e501eb77d121668b22cc533b744a3dc755
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list