Change in vdsm[ovirt-3.6]: hooks: ovs: set OVS devices UP

edwardh at redhat.com edwardh at redhat.com
Mon Apr 11 13:50:19 UTC 2016


Edward Haas has posted comments on this change.

Change subject: hooks: ovs: set OVS devices UP
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/55897/2/tests/functional/networkTestsOVS.py
File tests/functional/networkTestsOVS.py:

Line 153: for t in not_supported:
Line 154:     delattr(NetworkTest, t)
Line 155: 
Line 156: 
Line 157: # When we set OVS bond device up, it does not turn UP, but only UNKNOWN
> I agree. OVS tests requires some refactoring.
Please make sure we have a TODO card for this.
Line 158: def _fakeWaitForKnownOperstate(*args, **kwargs):
Line 159:     pass
Line 160: networkTests._waitForKnownOperstate = _fakeWaitForKnownOperstate
Line 161: 


-- 
To view, visit https://gerrit.ovirt.org/55897
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8af77c136a8f27d980f94647f78570b3da1e611
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list