Change in vdsm[master]: migration: Add retry on full capacity

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Mon Apr 11 12:13:15 UTC 2016


Michal Skrivanek has posted comments on this change.

Change subject: migration: Add retry on full capacity
......................................................................


Patch Set 27:

(1 comment)

https://gerrit.ovirt.org/#/c/52799/27/vdsm/virt/migration.py
File vdsm/virt/migration.py:

PS27, Line 332: while self._progress < 100:
> At first glance I don't like this, feels fragile.
what happened to my earlier suggestion " check for VM being down should be enough"

Would it not be enough?


-- 
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988fa2e501eb77d121668b22cc533b744a3dc755
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list