Change in vdsm[master]: net: test: fix custom bond option separator

phoracek at redhat.com phoracek at redhat.com
Mon Apr 11 12:05:04 UTC 2016


Petr Horáček has uploaded a new change for review.

Change subject: net: test: fix custom bond option separator
......................................................................

net: test: fix custom bond option separator

Changed custom bonding option separator introduced in
https://gerrit.ovirt.org/#/c/55827/
was not changed in functional tests. This problem is exposed only
with patch https://gerrit.ovirt.org/#/c/55865.

Change-Id: Ibbe216e4dac6a8588b23980d8c1253de1b0b2ac3
Bug-Url: https://bugzilla.redhat.com/1234867
Signed-off-by: Petr Horáček <phoracek at redhat.com>
---
M tests/functional/networkTests.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/55954/1

diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 78ea1aa..d541a53 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -2710,7 +2710,7 @@
             status, msg = self.setupNetworks(
                 {},
                 {BONDING_NAME: {'nics': nics,
-                                'options': 'custom=foo=bar mode=4'}},
+                                'options': 'custom=foo:bar mode=4'}},
                 NOCHK)
             self.assertEqual(status, SUCCESS, msg)
             self.assertBondExists(BONDING_NAME, nics)
@@ -2719,7 +2719,7 @@
                 # is used), but not reported by netinfo.
                 self._assert_exact_bond_opts(BONDING_NAME, ['mode=4'])
                 bond = self.vdsm_net.config.bonds.get(BONDING_NAME)
-                self.assertSetEqual(set(['mode=4', 'custom=foo=bar']),
+                self.assertSetEqual(set(['mode=4', 'custom=foo:bar']),
                                     set(bond.get('options').split()))
 
             status, msg = self.setupNetworks(


-- 
To view, visit https://gerrit.ovirt.org/55954
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibbe216e4dac6a8588b23980d8c1253de1b0b2ac3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>


More information about the vdsm-patches mailing list