Change in vdsm[master]: hooks: Add fcoe hook

phoracek at redhat.com phoracek at redhat.com
Mon Apr 11 10:42:28 UTC 2016


Petr Horáček has posted comments on this change.

Change subject: hooks: Add fcoe hook
......................................................................


Patch Set 18:

(1 comment)

https://gerrit.ovirt.org/#/c/55029/18/vdsm_hooks/fcoe/fcoe_before_network_setup.py
File vdsm_hooks/fcoe/fcoe_before_network_setup.py:

PS18, Line 90:         elif hooking.tobool(net_attr.get('remove')):
> Since which version? I can see type 'unicode' here
Since master. On 3.6, we need to use tobool.

However, if 'remove' is in attributes we do not accept other attribute and we usually test 'remove' existence, not its value.


-- 
To view, visit https://gerrit.ovirt.org/55029
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad2faed7205ca08801132df072b469dbe781318c
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list